-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rescript fails to build with glibc-2.34 #5494
Comments
For platforms without prebuilt binaries, ReScript is built from source in the npm postinstall script. If no usable OCaml compiler is found on the path, OCaml itself is built from source first. The OCaml sources are vendored inside the ReScript package as This used to be a customized 4.06 version, but the current master can be compiled with a stock OCaml 4.10+ compiler (CI is using 4.14.0). I just checked the current contents of
Looking at I guess we should replace this version with the OCaml 4.14.0 sources. This would resolve the problem for the upcoming ReScript 10 release, and it might be a good idea in any case to have npm postinstall builds use the same OCaml version as CI builds. |
Thank you for the quick resolution. Can I use this without having to wait for v10 release? I tried
|
Never mind. v10 alpha release is out! Works well. Thank you. |
I am facing the same issue with Node version -> Dependencies:
|
The prebuilt binary in my system (NixOS) is (probably) incompatible, forcing a build. However, the process fails with the error:
You can find the full log here: https://pastebin.com/Y2NyLvfH
I found an issue on ocaml repo (https://github.com/ocaml/ocaml/issues/10250 3) which talks about this issue. The root cause was determined to be a change in glibc 2.34.
glibc on my system is indeed 2.34.
The problem has been fixed in the stock OCaml compiler, but in the more recent (and stock) versions of the compiler. However, because rescript maintains a customized 4.06 version, the fix needs to be backported. As per my understanding, even the pre-built binaries won't build once everything in the world upgrades to glibc 2.34.
The text was updated successfully, but these errors were encountered: