Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional record fields rendered incorrectly in type errors #5654

Closed
cknitt opened this issue Sep 10, 2022 · 1 comment · Fixed by #5656
Closed

Optional record fields rendered incorrectly in type errors #5654

cknitt opened this issue Sep 10, 2022 · 1 comment · Fixed by #5656
Labels
Milestone

Comments

@cknitt
Copy link
Member

cknitt commented Sep 10, 2022

E.g.:

A.res:

type a = {x?: string}

A.resi:

type a = {y?: string}

=>

    Type declarations do not match:
         type rec a = {?x: string}
       is not included in
         type rec a = {?y: string}

It should be x?: string, not ?x: string.

And isn't rec incorrect, too?

@cristianoc cristianoc added the bug label Sep 10, 2022
@cristianoc cristianoc added this to the v10.1 milestone Sep 10, 2022
@cristianoc
Copy link
Collaborator

Thanks, probably the outcome printer.

The rec thing looks strange.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants