Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close the lock file after opening #5621

Merged
merged 2 commits into from
Aug 30, 2022
Merged

Conversation

hellos3b
Copy link
Contributor

This PR resolves an issue where fs.openSync is throwing a permission error on windows, preventing any building from happening.

View the linked issues for more information, attached is a screenshot of the lock file performing it's duty

image

Fixes #5620
Fixes #5617

@cristianoc cristianoc changed the base branch from master to 10.0_release August 30, 2022 15:40
@cristianoc cristianoc changed the base branch from 10.0_release to master August 30, 2022 15:41
Copy link
Collaborator

@cristianoc cristianoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Adding changelog for 10.0.1 then will cherry pick onto 10.0 branch.

@cristianoc cristianoc merged commit 8333e3f into rescript-lang:master Aug 30, 2022
@Mng12345
Copy link

@cristianoc Would the new version of the compiler will be published on the npm soon?

@cristianoc
Copy link
Collaborator

@cristianoc Would the new version of the compiler will be published on the npm soon?

Yes, perhaps even today.
CC @cknitt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants