Make promise a built-in type. #5650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleaner on hover and writing promise types explicitly.
cristianoc
force-pushed
the
builtin_promise
branch
from
e7091ed
to
f00443c
Compare
bobzhang
reviewed
Sep 10, 2022
| let rec extractPromise t = | ||
| match t.desc with | ||
| | Tconstr | ||
| (Pdot (Pdot (Pident { name = "Js" }, "Promise", _), "t", _), [ t1 ], _) |
There was a problem hiding this comment.
could this be made opt-in? If this is a built in type, I remember there're some faster check
There was a problem hiding this comment.
I would remove Js.Promise.t from js_promise.ml but that's a breaking change.
So as long as you can use it explicitly, it's easy to unintentionally disable the check.
Probably something to remove a little later when the feature is less experimental.
57 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaner on hover and writing promise types explicitly.