Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax: process uncurried types explicitly in the parser/printer. #5784

Merged
merged 9 commits into from
Nov 9, 2022

Conversation

cristianoc
Copy link
Collaborator

@cristianoc
Copy link
Collaborator Author

The CI fail is a good example of catching issues earlier now that the syntax repo has moved.

@cristianoc
Copy link
Collaborator Author

cristianoc commented Nov 8, 2022

One issue with this is that one loses the ability to convert uncurried types from .ml e.g. in type u0 = ?x:int -> y : string -> int [@bs] the uncurried attribute is currently ignored.

So either one loses that ability, or a duplicate printing mechanism is required where the ast with @bs and the one with arity are both supported for printing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant