Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix uncurried forwardRef component #5808

Merged
merged 2 commits into from
Nov 16, 2022
Merged

Conversation

mununki
Copy link
Member

@mununki mununki commented Nov 15, 2022

This PR fixes #5807

@mununki
Copy link
Member Author

mununki commented Nov 15, 2022

If PR is okay and ready, then going to add the changelog.

Copy link
Collaborator

@cristianoc cristianoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix

@@ -38,7 +38,8 @@ These are only breaking changes for unformatted code.

- Syntax: process uncurried types explicitly in the parser/printer https://github.com/rescript-lang/rescript-compiler/pull/5784
- Syntax: process uncurried function declarations explicitly in the parser/printer https://github.com/rescript-lang/rescript-compiler/pull/5794
- PPX V4: allow uncurried `make` function and treat it like a currie one https://github.com/rescript-lang/rescript-compiler/pull/5802
- PPX V4: allow uncurried `make` function and treat it like a curried one https://github.com/rescript-lang/rescript-compiler/pull/5802
Copy link
Member Author

@mununki mununki Nov 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed typo currie -> curried

@mununki mununki merged commit e65c3a3 into master Nov 16, 2022
@mununki mununki deleted the fix-uncurried-forward-ref branch November 16, 2022 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parse error for uncurried forwardRef component
2 participants