Treat uncurried application of primitives like curried application #5851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Primitives are treated specially in the type checker, so that when fully applied, no function is generated. With uncurried application, primitives are wrapped with eta expansion before being used, because the encoding via `Js.Internal.opaqueFullApply` disables the special treatment by the type checker. This PR treats uncurried application of primitives like curried application, to help `Lam` compilation produce better code instead of leaving eta-expanded functions in the output.
cristianoc
force-pushed
the
uncurried_primitives
branch
from
abc2d44
to
69baeda
Compare
|
See also #5847 which also addresses improving the generated code, via some Lam compilation optimisation. |
15 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primitives are treated specially in the type checker, so that when fully applied, no function is generated. With uncurried application, primitives are wrapped with eta expansion before being used, because the encoding via
Js.Internal.opaqueFullApplydisables the special treatment by the type checker. This PR treats uncurried application of primitives like curried application, to helpLamcompilation produce better code instead of leaving eta-expanded functions in the output.