Fix compiler ppx issue when combining async and uncurried application
#5856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristianoc
force-pushed
the
async_await_ppx
branch
from
be47881
to
f99baad
Compare
Fixes #5854 The compiler ppx for `async` and `await` was propagating annotations of the body. When the body happens to be an uncurried application, the `@res.app` annotation was propagated to the code generated by the PPX and produced a type error (E.g. it would generate an uncurried call to the internal function `unsafe_await`).
cristianoc
force-pushed
the
async_await_ppx
branch
from
f99baad
to
c69ed76
Compare
cknitt
approved these changes
Nov 27, 2022
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5854
The compiler ppx for
asyncandawaitwas propagating annotations of the body. When the body happens to be an uncurried application, the@res.appannotation was propagated to the code generated by the PPX and produced a type error (E.g. it would generate an uncurried call to the internal functionunsafe_await).