Fix build error where aliasing argument to _ in make function with jsx v4

[mununki]

This PR fixes #5880

[mununki]

A build error was caused here when meeting Ppat_any stops the loop.

[cristianoc]

@cknitt this should go into branch 10.1 ?

[cknitt]

Right, we need that in 10.1, too.
And on master there is a Windows CI issue when the syntax has changed, will look into that.

[mununki]

Need to rebase to 10.1_release?

[cknitt]

@mununki Yes, please, that would be great (but for 10.1 the change needs to be made in the syntax repo).

[mununki]

@mununki Yes, please, that would be great (but for 10.1 the change needs to be made in the syntax repo).

Not clear to me. Do I need to make another PR in the syntax repo? I thought the syntax repo was archived.

[cknitt]

Yes, you would need to make another PR in the syntax repo first, as the 10.1 release branch still has the syntax submodule.

[mununki]

Yes, you would need to make another PR in the syntax repo first, as the 10.1 release branch still has the syntax submodule.

Ah! I got it, remember that.

[mununki]

I made another PR in the syntax repo rescript-lang/syntax#720

[mununki]

@cknitt still does this branch need to be rebased to 10.1_release?

[cknitt]

You would need to create a new PR for the 10.1_release branch that uses the updated syntax (once your syntax PR is merged).

[mununki]

You would need to create a new PR for the 10.1_release branch that uses the updated syntax (once your syntax PR is merged).

If so, then I'm going to close this PR.

[cknitt]

Well, we still need the fix on master, too. :-)

[mununki]

Ooops, I reopen it 😄

[mununki]

The updating change log seems already done in #5884 (comment). If this PR doesn't need to update the change log in the compiler, let me know.

[cknitt]

Please rebase to latest master, the Windows build should work now.

[mununki]

Please rebase to latest master, the Windows build should work now.

Thanks. Rebased to master.