Cleanup uncurried #6080
Merged
Cleanup uncurried #6080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cknitt
reviewed
Mar 16, 2023
| @@ -24,10 +24,10 @@ subset of the arguments, and return a curried type with the remaining ones https | |||
| - Add support for default arguments in uncurried functions https://github.com/rescript-lang/rescript-compiler/pull/5835 | |||
| - Inline uncurried application when it is safe https://github.com/rescript-lang/rescript-compiler/pull/5847 | |||
| - Support optional named arguments without a final unit in uncurried functions https://github.com/rescript-lang/rescript-compiler/pull/5907 | |||
| - Add support for uncurried-always: a mode where everything is considered uncurried, whether with or without the `.`. This can be turned on with `@@uncurriedAlways` locally in a file. Added a project config `"uncurried"`, which propagates to dependencies, and takes the values: `"legacy"` which changes nothing, or `"default"` for uncurried by default, or `"always"` for uncurried-always. | |||
| - Add support for uncurried mode: a mode where everything is considered uncurried, whether with or without the `.`. This can be turned on with `@@uncurried` locally in a file. For project-level configuration in `bsconfig.json`, there's a boolean config `"uncurried"`, which propagates to dependencies, to turn on uncurried mode. | |||
There was a problem hiding this comment.
I think we should move this to the top of the list so that people read about this first, not about the "uncurried by default" mode.
Shouldn't the uncurried mode be labeled "experimental" for now, too?
There was a problem hiding this comment.
The changelog will need to be turned around to be in a simple consumable form.
For now, just logging what changes have been made, in case some bugs come up.
cknitt
reviewed
Mar 16, 2023
Rename `@@uncurried` to `@@uncurried.swap` so relegating it to tests only. Also simplify the setting in bsconfig, which now takes just a boolean.
The Config module is used by the compiler, so the `uncurried` setting needs to be reset on each file as tests compile several files on a single command line (actual project builds don't).
cristianoc
force-pushed
the
cleanup-uncurried
branch
from
e37b340
to
04f2c2c
Compare
cristianoc
added a commit
that referenced
this pull request
Mar 17, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use just
@@uncurriedfor what used to be called uncurried-always. (Just keep@@uncurried.swapfor syntax swap tests, but it's not planned to be user-facing). Also removed@@toUncurried.Simplify project setting to just a boolean:
"uncurried": true.