Make variant pattern matching not rely on tags being int #6085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are several ways in which the compilation of variants relies on tags being integers: - Sometimes it uses booleans `if x` to mean `x !=0` to mean: not the first variant (i.e. tag 0) - Sometimes it uses intervals `if (x > 3 || x < 1)` Care is required not to change the compilation of variants with special compilation: - true and false - lists have constructors "[]" and "::" - options have a specific definition for "Some" and "None" See #6077
cristianoc
force-pushed
the
pattern_match_variant
branch
from
5a74547
to
230269b
Compare
The only one that could still make sense is for the identity function, but that would be a strange optimization. Better have it earlier on, and apply to partial cases too, where it's mostly the identity.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several ways in which the compilation of variants relies on tags being integers:
if xto meanx !=0to mean: not the first variant (i.e. tag 0)if (x > 3 || x < 1)Care is required not to change the compilation of variants with special compilation: