Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit tags as strings. #6088

Merged
merged 8 commits into from
Mar 24, 2023
Merged

Emit tags as strings. #6088

merged 8 commits into from
Mar 24, 2023

Commits on Mar 23, 2023

  1. Emit tags as strings.

    @cristianoc
    cristianoc committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    61f8598 View commit details
    Browse the repository at this point in the history

  2. Remove tests with @deriving(jsConverter)

    @cristianoc
    cristianoc committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    24e85f3 View commit details
    Browse the repository at this point in the history

  3. Support inline records

    @cristianoc
    cristianoc committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    29287d1 View commit details
    Browse the repository at this point in the history

  4. Allow more general type for tags. 

    Compile is_tag to `!== "object"` instead of `=== "string"`.
    @cristianoc
    cristianoc committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    6b4478f View commit details
    Browse the repository at this point in the history

  5. Remove support for @deriving(jsConverter)

    @cristianoc
    cristianoc committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    6793a9e View commit details
    Browse the repository at this point in the history

  6. Do not special case variants with only 1 case with payload. 

    Also the comment is not emitted anymore, since there's always a tag.
Not special casing means that the representation is uniform, and does not change when the type is extended. This is important with zero cost ffi, where the runtime representation is exposed to the user, to reduce possible surprises.
    @cristianoc
    cristianoc committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    ae4de45 View commit details
    Browse the repository at this point in the history

  7. Fix pattern matching with 2 variant, that was compiled like booleans.

    @cristianoc
    cristianoc committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    2524fca View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2023

  1. Update CHANGELOG.md

    @cristianoc
    cristianoc committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    46ed9f6 View commit details
    Browse the repository at this point in the history