Emit directive above header comment (v11)

[aspeddro]

Close #6170

[cristianoc]

Great.
It looks like the test we have directive.res is not affected probably just because of how the compilation of tests happens, without generating header comments.

[cristianoc]

Indeed this is from test/build.ninja:

bsc_flags = -bs-no-version-header  -bs-cross-module-opt -make-runtime-test -bs-package-output commonjs:jscomp/test  -w -3-6-26-27-29-30-32..40-44-45-52-60-9-106+104 -warn-error A  -I runtime -I $stdlib -I others

Some tests change the bsc flags locally in the file. Let me look up how that's done.

[cristianoc]

Here's an example:

@@config({flags: ["-bs-gentype"]})

[cristianoc]

One could in principle go here:

    "-bs-no-version-header", set Js_config.no_version_header,
    "*internal*Don't print version header";

and add an option to turn it back on.
Or just don't bother for such a simple test.

[cristianoc]

Happy to merge as-is, or if you'd like to change something in the tests just lmk.

[aspeddro]

I can remove the -bs-no-version-header flag on:

rescript-compiler/scripts/ninja.js

Line 1200 in c0d0ae0

bsc_flags = -bs-no-version-header -bs-cross-module-opt -make-runtime-test -bs-package-output commonjs:jscomp/test -w -3-6-26-27-29-30-32..40-44-45-52-60-9-106+104 -warn-error A -I runtime -I $stdlib -I others

In that case all tests will have the header.

[cristianoc]

I can remove the -bs-no-version-header flag on:

rescript-compiler/scripts/ninja.js

Line 1200 in c0d0ae0

bsc_flags = -bs-no-version-header -bs-cross-module-opt -make-runtime-test -bs-package-output commonjs:jscomp/test -w -3-6-26-27-29-30-32..40-44-45-52-60-9-106+104 -warn-error A -I runtime -I $stdlib -I others

In that case all tests will have the header.

That sounds good to me. No reason why test file should look different from normal compiled files.

[cristianoc]

Good