Add support for functions in untagged variants. #6279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was done at speed: need to double check that there are no corner cases missing. Fixes #6278
cristianoc
commented
Jun 1, 2023
| @@ -298,6 +311,8 @@ module DynamicChecks = struct | |||
| typeof e != number | |||
| | ArrayType -> | |||
| not (is_array e) | |||
| | FunctionType -> | |||
| typeof e != function_ | |||
There was a problem hiding this comment.
Functions cannot overlap with literals so this case should be OK.
| @@ -341,9 +356,8 @@ module DynamicChecks = struct | |||
| let add_runtime_type_check ~tag_type ~(block_cases: block_type list) x y = | |||
| let has_array() = Ext_list.exists block_cases (fun t -> t = ArrayType) in | |||
| match tag_type with | |||
| | Untagged IntType | |||
| | Untagged StringType | |||
| | Untagged FloatType -> typeof y == x | |||
There was a problem hiding this comment.
This seems OK as functions can't overlap with int, string, float, object, array.
|
Works as expected! |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was done at speed: need to double check that there are no corner cases missing.
Fixes #6278
TODO: