Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix printing of type constraints in template literal substitutions #6324

Merged
merged 3 commits into from
Jul 8, 2023
Merged

Fix printing of type constraints in template literal substitutions #6324

merged 3 commits into from
Jul 8, 2023

Conversation

glennsl
Copy link
Contributor

@glennsl glennsl commented Jul 7, 2023

Fixes #6319

cristianoc
cristianoc approved these changes Jul 8, 2023
View reviewed changes
Copy link
Collaborator

@cristianoc cristianoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!
Would you add a changelog?
Even a single one for both this and the other fix.

@glennsl glennsl mentioned this pull request Jul 8, 2023
Merged
@cristianoc cristianoc merged commit 18a2f2f into rescript-lang:master Jul 8, 2023
14 checks passed
@glennsl glennsl deleted the fix/printer/type-constraint-in-template-literal branch July 8, 2023 12:14
@fhammerschmidt fhammerschmidt mentioned this pull request Oct 2, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristianoc cristianoc cristianoc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Syntax: Parens required around type expressions but dropped by formatter
2 participants
@glennsl @cristianoc