Fix outcome printer in uncurried mode #6353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rest of the code does
zth
force-pushed
the
uncurried-outcome-printer
branch
from
2796c6c
to
b75ed93
Compare
cristianoc
approved these changes
Aug 17, 2023
It solves the things in the editor tooling. For the rest we'll need to merge this and also merge the uncurried fixes branch in the editor tooling. Plus someone who can reproduce the issues, I haven't tried myself yet. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The outcome printer was deciding whether something is uncurried or not in its own way. Probably just an oversight when centralizing how uncurried config is resolved. I changed it to resolve the uncurried config the same way as the rest of the code does.
This might fix a few issues we've had with formatting being with dots even when it shouldn't be. Hopefully.