Gentype: fix issue with labelled args which should not be grouped. #6406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Grouping labelled args is a leftover incompatible with zero cost conversion. Fixes #6361
cristianoc
force-pushed
the
gentype-labeled-args
branch
from
5d80367
to
f1a7cb0
Compare
zth
approved these changes
Sep 18, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Grouping labelled args is a leftover incompatible with zero cost conversion.
Fixes #6361
There's no nice way to represent optional labeled args. Currently represented as mandatory args of option type. Also, there's no much choice as that's what the compiler produces.