Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treat rescript as rescript build aka rescript -w support 馃殌 #6524

Merged
merged 3 commits into from
Dec 14, 2023
Merged

Treat rescript as rescript build aka rescript -w support 馃殌 #6524

merged 3 commits into from
Dec 14, 2023

Conversation

DZakh
Copy link
Contributor

@DZakh DZakh commented Dec 12, 2023

If rescript is called with a flag other than help or version, it'll be treated as rescript build command.

So now you can use rescript -w.

I've moved some code to make args parsing code more readable. Besides var->const/let changes, the code is the same.

DZakh
DZakh commented Dec 12, 2023
View reviewed changes
rescript Show resolved Hide resolved
cknitt
cknitt reviewed Dec 13, 2023
View reviewed changes
Copy link
Member

@cknitt cknitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in two projects and it worked fine.

I assume the code in rescript_bsb.js was only moved from rescript and does not contain any other changes?

jscomp/build_tests/cli_help/input.js Show resolved Hide resolved
@JonoPrest JonoPrest mentioned this pull request Dec 13, 2023
Merged
@DZakh
Copy link
Contributor Author

DZakh commented Dec 14, 2023

and does not contain any other changes?

It contains some var -> let/const renaming, and dlog creation is slightly different. Other than this, everything is the same.

@cknitt cknitt merged commit 63ef9e5 into rescript-lang:master Dec 14, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cknitt cknitt cknitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DZakh @cknitt