Remove redundant space for export js dump #6560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's a pr to generate let instead of var, and fix some issues due to that. |
|
The PR is ready for review |
|
Should I retarget it to master? |
|
Yes, please retarget to master. |
DZakh
force-pushed
the
fix-export-js-dump
branch
from
7f0c622
to
0bd7367
Compare
DZakh
force-pushed
the
fix-export-js-dump
branch
from
aef7bb7
to
5048436
Compare
|
@cknitt Updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is worth being a part of the
v11.1release. What's the process should be?