Remove remaining "bs." attributes #6643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cknitt
commented
Feb 18, 2024
| @@ -27,12 +27,11 @@ | |||
| it may fail third party ppxes | |||
| *) | |||
| let is_bs_attribute txt = | |||
There was a problem hiding this comment.
This was not invoked for the non-bs attributes and therefore the unused attribute check was not working for those, see #6636.
Some more investigation needed though as adding "as" causes tests to fail. This should be done in a separate PR.
cknitt
force-pushed
the
no-bs
branch
3 times, most recently
from
9fef100
to
78ba5d8
Compare
zth
approved these changes
Feb 20, 2024
JonoPrest
pushed a commit
to JonoPrest/rescript-compiler
that referenced
this pull request
Mar 21, 2024
* @bs.string -> @string * @bs.this -> @this * @bs.uncurry -> uncurry * @bs.unwrap -> @unwrap * @bs.val -> @Val * @bs.debugger -> @debugger * @bs.external -> @external * @bs.raw -> @raw * @bs.re -> @re * @bs.time -> @time * @bs.config -> @config * Cleanup * Changelog * Deactivate unused argument check for @int
This was referenced May 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the remaining
@bs.xxxattributes and clean up.Also (mostly) fixes #6636.
The only remaining one is the deprecated
@bs.send.pipewhich is still in use in theJsmodule. Not sure how to proceed with that one.