Fix the incorrect type annotation for ref in JSX4 #6718
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6714
In the Discouraged ForwardRef use case, if
ref
did not have a type annotation, JSX4 added an incorrect type as an annotation during transformation. While this PR change may cause build errors where the type'ref
cannot be generalized, I don't think it will be a problem because in most cases the type ofref
can be inferred from the ForwardRef component implementation. I think adding an incorrect type is a bigger problem.Original
Before this change
After this chage