Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix indent for returned/thrown/wrapped in parentheses objects in generated js code #6746

Merged
merged 5 commits into from Apr 28, 2024
Merged

Fix indent for returned/thrown/wrapped in parentheses objects in generated js code #6746

merged 5 commits into from Apr 28, 2024

Conversation

DZakh
Copy link
Contributor

@DZakh DZakh commented Apr 28, 2024

No description provided.

cknitt
cknitt approved these changes Apr 28, 2024
View reviewed changes
Copy link
Member

@cknitt cknitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks a lot! 👍

Not sure if there might be any conflicts with #6102 in the JS output? Let's get that one merged first maybe.

@DZakh
Copy link
Contributor Author

DZakh commented Apr 28, 2024

It's just a matter of running make test after merging changes. I have another pr prepared, so I'd like to have this merged

@cknitt
Copy link
Member

cknitt commented Apr 28, 2024

Ok, then let's merge this one first (can't wait for the next one 😄).

@cknitt cknitt merged commit 4738476 into rescript-lang:master Apr 28, 2024
14 checks passed
@DZakh
Copy link
Contributor Author

DZakh commented Apr 28, 2024

There is more indent clean up. I'll prepare a pr when I'm back home 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cknitt cknitt cknitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DZakh @cknitt