Skip to content
This repository has been archived by the owner on Jun 15, 2023. It is now read-only.

Pipe reformat eats annotation #629

Merged
merged 5 commits into from Sep 2, 2022
Merged

Pipe reformat eats annotation #629

merged 5 commits into from Sep 2, 2022

Conversation

cristianoc
Copy link
Contributor

No description provided.

@cristianoc
Copy link
Contributor Author

There are some roundtrip issues too.

@cristianoc cristianoc added this to the v10.1 "The New Features" milestone Sep 1, 2022
cristianoc
cristianoc commented Sep 2, 2022
View reviewed changes
src/res_printer.ml
@@ -3658,6 +3658,7 @@ and printBinaryExpression ~customLayout (expr : Parsetree.expression) cmtTbl =
Doc.group
(Doc.concat
[
printAttributes ~customLayout expr.pexp_attributes cmtTbl;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seen this one before perhaps?
https://github.com/rescript-lang/syntax/pull/621/files#diff-5f509cef22744d6c22d0c7a7fc37bcb68a1bda23db28caa9dc2b20cdbfebb695R3661

@cristianoc
Copy link
Contributor Author

The roundtrip tests failing are:

-let s1 = @ann x->foo
+let s1 = (@ann x)->foo
 let s2 = @ann foo(x)
-let s3 = @ann x |> foo
+let s3 = (@ann x) |> foo

indicating a printing issue

@cristianoc cristianoc merged commit 94ae874 into master Sep 2, 2022
@cristianoc cristianoc deleted the pipe-reformat-eats-annotation branch September 2, 2022 05:01
@cristianoc cristianoc mentioned this pull request Sep 27, 2022
Closed
57 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v10.1 "The New Features"
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@cristianoc