Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade rescript version #9

Merged
merged 1 commit into from Apr 8, 2024
Merged

Conversation

DCKT
Copy link
Contributor

@DCKT DCKT commented Aug 2, 2023

No description provided.

@Freddy03h
Copy link
Member

@MoOx what's the strategy for releasing a new version?

@DCKT
Copy link
Contributor Author

DCKT commented Oct 20, 2023

This is a personal take but I think we should leave the 1:1 version idea of bindings.
It's works well when the bindings can be done in one version but for big packages like react-navigation where there are a LOT of options it would obviously could not follow the package version at some point.

It should just at least match the minor version (1.X) or be clear in the readme with a table like this :

Bindings Package
2.X >= 2.X
1.X < 2.X

@Freddy03h
Copy link
Member

Freddy03h commented Oct 25, 2023

@DCKT I find it's usefull to not have to check each time I want to upgrade a package and its binding, for each dependencies.

But yes it's not designed for when you need to make a rescript related update…

@MoOx
Copy link
Member

MoOx commented Dec 6, 2023

I will stick to 1:1 version even if that's breaking for some people.
This bindings are probably used by a niche anyway.

@MoOx
Copy link
Member

MoOx commented Dec 6, 2023

@Freddy03h
Copy link
Member

@MoOx So you recommend a 4.x.0 version for a rescript upgrade?

@MoOx
Copy link
Member

MoOx commented Dec 6, 2023

Yes ! With proper notice in changelog :)

@Freddy03h Freddy03h merged commit c3a1ebb into rescript-react-native:main Apr 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants