Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False menu items such as "(Windows Boot Manager, )" with Rescuezilla v1.0.5.1 #69

Closed
shasheene opened this issue May 19, 2020 · 5 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@shasheene
Copy link
Member

shasheene commented May 19, 2020

A user recently reported not being able to see an "ADATA m.2 NVMe SSD source drive", claiming to have seen this issue on Rescuezilla v1.0.5.1. The user uploaded a log file when requested.

From this log file, it can be inferred that Rescuezilla v1.0.5.1 is indeed being used, as an ISO9660 filesystem labelled Rescuezilla sized at 666MB is present (side note: added 5ab9dd7 in response to this bug report, so that in future such inferring of the version from the log won't be needed).

The key part of the log appears to be right at the start (lsblk: /dev//dev/nvme0n1p1: not a block device). This indicates the output of either os-prober or fsarchiver probe command (which provides the data used in a call to lsblk --noheadings --output=pkname --nodeps /dev/$input_partition) has has been prepended with "/dev/".

Further examination suggests the root cause is os-prober, having been broken when NVMe support was added (regressions like these can be fixed with unit tests, which are planned with #49).

@shasheene shasheene added the bug Something isn't working label May 19, 2020
@shasheene shasheene added this to the v1.0.6 milestone May 19, 2020
@shasheene shasheene self-assigned this May 19, 2020
@shasheene
Copy link
Member Author

@billlum

Thanks for reporting the issue. Did you see a screen similar to the image below?

os-prober nvme issue

Rescuezilla v1.0.5.1 is not merging the menu entries. For now, it should be possible to workaround the issue by selecting the menu item starting with "Drive" that corresponds to the correct hard drive capacity.

Rescuezilla v1.0.6 will be released in a few weeks with this issue (and many others) fixed.

@billlum
Copy link

billlum commented May 19, 2020

@shasheene thanks to your advice, I completed the backup successfully!!
Btw, I'm a Patreon contributor and looking forward to your great work in v1.0.6!

@shasheene
Copy link
Member Author

@billlum

I thought I had recognized the name, but I couldn't remember where from. Thanks for your generous support!

As you may have seen, there are many bug fixes coming in Rescuezilla v1.0.6, but from the log file you provided it looks like these issues won't affect your Windows backup at all.

Let me know if you have any issues.

@billlum
Copy link

billlum commented May 20, 2020 via email

@shasheene shasheene changed the title Partitions (of NVMe drive) not showing up using Rescuezilla v1.0.5.1 Spurious (and broken) menu items eg "(Windows Boot Manager, )" with Rescuezilla v1.0.5.1 May 20, 2020
@shasheene shasheene changed the title Spurious (and broken) menu items eg "(Windows Boot Manager, )" with Rescuezilla v1.0.5.1 False menu items such as "(Windows Boot Manager, )" with Rescuezilla v1.0.5.1 May 20, 2020
shasheene added a commit to shasheene/rescuezilla-dev that referenced this issue May 20, 2020
Prevents spurious items in the device selection menu by removing the leading
"/dev/" string (and EFI bootloader string) from the output of `os-prober` and
ensuring the device string gets correctly processed by the NVMe support
functions.

Also prints out the `os-prober` output to STDOUT (and thus written to log
file), which helps with any future debugging.

This regression occurred when NVMe support was integrated. Unit tests have not
been added in this commit, but will be done as part of rescuezilla#49.

Fixes rescuezilla#69
Rescuezilla v1.0.6 Milestone Kanban Board automation moved this from In progress to Done May 20, 2020
@shasheene
Copy link
Member Author

This issue has been fixed by Rescuezilla v1.0.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Development

No branches or pull requests

2 participants