Remove accidental unmount of source partition #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensures the source partition (eg, /dev/sdb1) is NOT unmounted during a restore operation. Unmounting this was mistakenly added in a recent commit. [1] Given the source partition is read from a file not a block device, the source partition variable ($part) only indicates what the original source partition device node was, so is mostly not relevant during the restore process. In fact, if the sdb1 partition happens to be the source drive where the backups are stored, this breaks the restore operation. This breakage was not caught during testing of the prior commit as backup drive and the original partition being restored happened to not have the same device node string. [1] 8f4f0db
Removes unnecessary printing of the number of busy device nodes, which was used for debug purposes during development of a prior commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent commit added a retry msg box to unmount busy partitions. During a restore operation, unmounting the source partition was added and the commit tested without issue. However, the source partition variable during a restore operation contains the original device node used during the backup operation, which may have been on a different computer. Thus this device node has no bearing on the restore operation, and it may even happen to be the device node that holds the backup files being restored (causing the restore to fail). This partition should therefore not be unmounted.