Skip to content

Commit

Permalink
broker config should be nullable
Browse files Browse the repository at this point in the history
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
  • Loading branch information
vsoch committed Jul 3, 2023
1 parent 00e1d98 commit f91a44e
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 0 deletions.
4 changes: 4 additions & 0 deletions fluxfw-gcp/img/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,11 @@ build Flux Framework GCP images.
### Packer Build Step Creation

The command

```bash
./create-buildstep.sh
```

clones the [cloud builders community](https://github.com/GoogleCloudPlatform/cloud-builders-community) repo, determines the current latest
Packer version and then invokes Cloud Build to create the Packer build step.

Expand All @@ -27,9 +29,11 @@ Packer version and then invokes Cloud Build to create the Packer build step.
The Packer build step requires elevated privileges to create a GCP image. Rather than grant those privileges
to the Cloud Build service account a separate `image builder` service account is created and granted the
necessary privileges. The command

```bash
./builder-setup.sh
```

creates the `image builder` service account the necessary privileges, downloads its keys, uses the Google Cloud KMS service
to encrypt them and grants the Cloud Build service account the ability to decrypt them.

Expand Down
1 change: 1 addition & 0 deletions fluxfw-gcp/tf/variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ variable "broker_config" {
description = "A custom broker config (system.toml) to provide to the manager"
type = string
default = ""
nullable = true
}

variable "cluster_storage" {
Expand Down

0 comments on commit f91a44e

Please sign in to comment.