Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal to add commitOptions to git config -- Update GitAdapter.groovy #367

Merged
merged 1 commit into from Aug 30, 2022

Conversation

loosebazooka
Copy link
Contributor

@loosebazooka loosebazooka commented Aug 19, 2022

Proposal for adding git commit options.

This means a user can do something like ["-s"] to satisfy DCO bots: https://github.com/apps/dco

Copy link
Collaborator

@Hillkorn Hillkorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me to add this. Can you add it to the README and write tests for it please.
Thought about an explicit config for signing like we have for tags but I personally prefer a generic option.

@loosebazooka
Copy link
Contributor Author

loosebazooka commented Aug 25, 2022

Thought about an explicit config for signing like we have for tags but I personally prefer a generic option.

To me there's a very strong difference between "signing" and "signing-off" here. I'm mostly concerned with -s "sign-off" to satisfy the DCO bot, but I think the word "signing" would more align with -S.

I'll keep this generic for now.

This means a user can do something like ["-s"] to satisfy DCO bots: https://github.com/apps/dco
@Hillkorn Hillkorn merged commit bd1f890 into researchgate:main Aug 30, 2022
@loosebazooka loosebazooka deleted the patch-2 branch August 30, 2022 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants