Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle ref objects in children. #47

Merged
merged 1 commit into from
Oct 23, 2018

Conversation

joaovieira
Copy link
Contributor

@joaovieira joaovieira commented Oct 22, 2018

Description

Handle children refs created with React.createRef.

Motivation and context

Fixes #46

How has this been tested?

Unit test + local project.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the code style of this project
  • I have read the CONTRIBUTING document
  • I have added tests to cover my changes
  • All new and existing tests passed

@Rendez
Copy link
Contributor

Rendez commented Oct 23, 2018

Thank you, this is great! My concern here is about those using the typings. Should wait for those to be updated? Or inform about it in the docs so that users of this library know that it is ok to add ts-lint ignore for the time being?

@joaovieira
Copy link
Contributor Author

joaovieira commented Oct 23, 2018 via email

@Rendez Rendez merged commit 609e1a5 into researchgate:master Oct 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support React.RefObject in React >=16.3
2 participants