children props should be typed as ReactNode
#72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rendez
approved these changes
Sep 26, 2019
|
We're waiting for a release cut of the |
|
Thank you for your review! (And I'm sorry for leaving this p-r as WIP 🙇) |
|
Thanks again. |
danez
pushed a commit
that referenced
this pull request
Nov 23, 2019
Rendez
pushed a commit
that referenced
this pull request
Nov 23, 2019
## [1.0.3](v1.0.2...v1.0.3) (2019-11-23) ### Bug Fixes * **typings:** children props should be ReactNode ([#72](#72)) ([43aa3a2](43aa3a2)), closes [/github.com/DefinitelyTyped/DefinitelyTyped/blob/41fe335d209b4cd46dedafd1a91849d7fec6880d/types/react/index.d.ts#L1218-L1222](https://github.com//github.com/DefinitelyTyped/DefinitelyTyped/blob/41fe335d209b4cd46dedafd1a91849d7fec6880d/types/react/index.d.ts/issues/L1218-L1222)
|
Thank you too! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref. https://github.com/DefinitelyTyped/DefinitelyTyped/blob/41fe335d209b4cd46dedafd1a91849d7fec6880d/types/react/index.d.ts#L1218-L1222
Description
childrenprops of React Components should have type ofReact.ReactNode.Motivation and context
childrenof React Component may not only be Component but can be another forms, such as text node or else.FYI: definition of
Propstype in @types/react also typeschildrenasReactNode.https://github.com/DefinitelyTyped/DefinitelyTyped/blob/41fe335d209b4cd46dedafd1a91849d7fec6880d/types/react/index.d.ts#L1218-L1222
How has this been tested?
Not tested well, but I think this change will not break anything.
Screenshots (if relevant):
Type of change
I think this is not breaking change because type
React.NodeacceptsReact.Component.Checklist: