Add workaround for the issue with react events inside web components. #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ponents. This is ugly hack to workaround issue with event propagation when react root is inside custom web component. See facebook/react#9242 This issue caused strange behaviour of platform components inside semantic-map popovers and Mirador annotation popovers. Basically even `semantic-link` was not working properly there and instead of changing the content of the page dynamically it reloaded the whole page. Or for example it was not possible to use `mp-event-trigger` in such context. Signed-off-by: Artem Kozlov <artem@rem.sh>
DawsonMacPhee
pushed a commit
to DawsonMacPhee/researchspace
that referenced
this pull request
Nov 24, 2021
…in-webcomponents Add workaround for the issue with react events inside web components.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is ugly hack to workaround issue with event propagation when react root is inside custom web component.
See facebook/react#9242
This issue caused strange behavior of platform components inside semantic-map popovers and Mirador annotation popovers.
Basically even
semantic-linkwas not working properly there and instead of changing the content of the page dynamically it reloaded the whole page.Or for example it was not possible to use
mp-event-triggerin such context.Signed-off-by: Artem Kozlov artem@rem.sh