Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat less cluttered post content #2637

Merged
merged 12 commits into from Jan 23, 2019

Conversation

sigpie
Copy link
Contributor

@sigpie sigpie commented Jan 11, 2019

Contributes to #2599

Hides Facets, Flags, Matching Context and some Type details by default. All information is shown if showRdf is enabled, as most of this information is only needed for debugging purposes or power users.

@sigpie sigpie added the testing label Jan 11, 2019
@quasarchimaere
Copy link
Contributor

i would not merge this, some facets (eg groupfacet) and some flags (matchingflags) as well as the matchingContext are very valuable information... not only to the developer but also to the user, i agree that we might want to reduce the clutter by hiding some of the content but we should not hide it in general, we might also be able to find better labels for the items

@sigpie
Copy link
Contributor Author

sigpie commented Jan 15, 2019

As far as I can tell, there's two flags and one facet that might be of interest for users:

  • No Hints for counterpart - maybe show this as "Invisible"
  • No Hints for me - maybe show this as "No Matches"
  • Group Facet - maybe show this as "Group Chat enabled"

Are there any other flags that should be always visible?

@sigpie sigpie force-pushed the feat_less-cluttered-post-content branch from 7af206f to 63488c1 Compare January 16, 2019 12:48
@sigpie
Copy link
Contributor Author

sigpie commented Jan 16, 2019

Force-pushed after rebasing on current master.

@sigpie
Copy link
Contributor Author

sigpie commented Jan 17, 2019

Changed behaviour to include matching context, group chat facet and "No hint for..." flags.

@quasarchimaere quasarchimaere merged commit 6846107 into master Jan 23, 2019
@quasarchimaere quasarchimaere deleted the feat_less-cluttered-post-content branch January 23, 2019 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants