fix(render): Tests for the web env not using the server.browser version of react-dom/server #1117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
vcapretz
approved these changes
Apr 4, 2024
gabrielmfern
added a commit
that referenced
this pull request
Apr 26, 2024
…on of react-dom/server (#1117)
gabrielmfern
added a commit
that referenced
this pull request
Apr 26, 2024
…on of react-dom/server (#1117)
gabrielmfern
added a commit
that referenced
this pull request
Apr 26, 2024
…on of react-dom/server (#1117)
gabrielmfern
added a commit
that referenced
this pull request
Apr 29, 2024
…on of react-dom/server (#1117)
gabrielmfern
added a commit
that referenced
this pull request
Apr 29, 2024
…on of react-dom/server (#1117)
gabrielmfern
added a commit
that referenced
this pull request
Jul 3, 2024
…on of react-dom/server (#1117)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bit of time ago I implemented a few unit tests for the
renderAsyncthat would simulate the different environments like the edge, node, and browser. But there was a small flaw on the test for the browser environment, where it was still importing the wrongreact-dom/server, so this PR fixes that.Other changes are just minor house-keeping things, like the changes on
packages/react-emailare due to linting issues or the upgrade tovitestwhich also adds in the removal of the\\escaping characters.