New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: changing the response types to keep consistency with Resend docs #109

Open

pedroimpulcetto wants to merge 4 commits into resend:main from pedroimpulcetto:fix/return-types

Contributor

pedroimpulcetto commented Jun 1, 2024

The idea here is to keep consistency with Resend Docs.

I tried to follow:

each .get method returns the object related
resend.Audiences.get(..) -> Audience:
resend.Contacts.get(..) -> Contact:
each .list method returns a list of "short" object related
FYI: a short object is an object with fewer attributes than the object or
ShortAudience ; ShortContact
the other methods, .create, .remove, etc return a "response" object
resend.Domains.CreateResponse ; resend.Domains.VerifyResponse

pedroimpulcetto added 4 commits

May 31, 2024 21:20


          fix: changing the response types to keep consistency with Resend docs

cef3fd6


          fix: creating a literal string for region attribute

8c3eab4


          fix: flake8

e94ce93


          fix: flake8 whitepasce

dcbdc63

drish self-requested a review

June 3, 2024 14:44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment