Zero distribution #878
Zero distribution #878
Conversation
| emitted: true, | ||
| }, | ||
| { | ||
| contract: token1, |
There was a problem hiding this comment.
i dont think this should fire?
There was a problem hiding this comment.
Agreed, it has emitted: false to check for that.
There was a problem hiding this comment.
We dont need the args param if we are checking for emitted = false, maybe thats the confusion.
| args: [rTokenTrader.address, backingManager.address, issueAmount.add(1)], | ||
| emitted: true, | ||
| }, | ||
| { |
There was a problem hiding this comment.
i don't think this should fire?
| emitted: true, | ||
| }, | ||
| { | ||
| contract: token1, |
There was a problem hiding this comment.
We dont need the args param if we are checking for emitted = false, maybe thats the confusion.
| } else if (address(tokenToBuy) == address(main.rToken())) { | ||
| require(revTotals.rTokenTotal == 0, "rTokenTotal > 0"); | ||
| } else { | ||
| revert("invalid tokenToBuy"); |
There was a problem hiding this comment.
This is not going to be covered with our default tests. So we can either deploy a standalone mock case with a RevTrader initialized to another tokenToBuy (not generally what we do in most tests as it would not be our "interface") or we add the untestable comment
Resolves code-423n4/2023-06-reserve-findings#34