Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C4 39 use comet decimals instead of wrapper decimals. #889

Merged
merged 4 commits into from Aug 22, 2023

Conversation

pmckelvy1
Copy link
Collaborator

No description provided.

@pmckelvy1 pmckelvy1 changed the title use comet decimals instead of wrapper decimals. C4 39 use comet decimals instead of wrapper decimals. Aug 10, 2023
@pmckelvy1 pmckelvy1 requested a review from tbrent August 11, 2023 19:58
@pmckelvy1 pmckelvy1 changed the base branch from 3.0.0-rc5 to 3.0.0-rc6 August 14, 2023 18:05
@@ -53,7 +53,8 @@ contract CTokenV3Collateral is AppreciatingFiatCollateral {
}

function _underlyingRefPerTok() internal view virtual override returns (uint192) {
return shiftl_toFix(ICusdcV3Wrapper(address(erc20)).exchangeRate(), -int8(erc20Decimals));
return
shiftl_toFix(ICusdcV3Wrapper(address(erc20)).exchangeRate(), -int8(comet.decimals()));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can cache as immutable var

@tbrent
Copy link
Contributor

tbrent commented Aug 21, 2023

LGTM

@tbrent tbrent merged commit 1b37c77 into 3.0.0-rc6 Aug 22, 2023
8 checks passed
@tbrent tbrent deleted the c4-plugins-39 branch August 22, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants