C4: #35 #32, fixes rETH / cbETH / ankrETH ref unit and adds soft default checks #899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jankjr
force-pushed
the
audit/cb-eth-units
branch
from
2a592c5
to
5d7b0a7
Compare
jankjr
force-pushed
the
audit/cb-eth-units
branch
from
5d7b0a7
to
d7f9211
Compare
tbrent
reviewed
Aug 18, 2023
|
So the way out of this confusion was to get the units right. The 2nd feeds should be targetPerTok feeds instead of refPerTok, because the ref unit is ETH2. This suddenly clears everything up and makes it super obvious, and leads to, for example, catching that the pegPrice should be the reciprocal of what it was. |
|
@akshatmittal tagging you in on this one. believe it is correct now |
|
err -- @akshatmittal I'll save you some time since you're reviewing other PRs too, tagging in @pmckelvy1 |
pmckelvy1
requested changes
Aug 22, 2023
tbrent
changed the title
pmckelvy1
requested changes
Aug 22, 2023
test/plugins/individual-collateral/ankr/AnkrEthCollateralTestSuite.test.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CBEth: Uses oracle rather contract method to convert from tok to ref as outlined in raised report.
RETH: Same modification made as RETH is more or less implemented the same way.