Skip to content

Commit

Permalink
Merge pull request #1 from reservoir-data/bump-singer-sdk
Browse files Browse the repository at this point in the history
chore: Bump `singer-sdk` to 0.37.0a4
  • Loading branch information
edgarrmondragon committed Apr 26, 2024
2 parents aa1c35a + af9f31f commit f62833c
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 9 deletions.
3 changes: 2 additions & 1 deletion .vscode/settings.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{
"cSpell.words": [
"datetime",
"polarsh"
]
}
}
2 changes: 0 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -99,8 +99,6 @@ tap-polarsh --config CONFIG --discover > ./catalog.json

## Developer Resources

- [ ] `Developer TODO:` As a first step, scan the entire project for the text "`TODO:`" and complete any recommended steps, deleting the "TODO" references once completed.

### Initialize your Development Environment

```bash
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ dynamic = [
]
dependencies = [
"requests~=2.31",
"singer-sdk~=0.37.0a3",
"singer-sdk~=0.37.0a4",
]
optional-dependencies.dev = [
"tap-polarsh[testing,typing]",
Expand Down
6 changes: 3 additions & 3 deletions tap_polarsh/streams.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ def generate_child_contexts(
self,
record: dict[str, t.Any],
context: dict[str, t.Any] | None, # noqa: ARG002
) -> t.Iterable[dict | None]:
) -> t.Iterable[dict[str, t.Any] | None]:
"""Generate child contexts."""
yield {
"organization_id": record["id"],
Expand Down Expand Up @@ -61,6 +61,6 @@ def get_url_params(
"""Get URL query parameters."""
return {
**super().get_url_params(context, next_page_token),
"platform": context["platform"],
"organization_name": context["organization_name"],
"platform": context["platform"] if context else None,
"organization_name": context["organization_name"] if context else None,
}
4 changes: 2 additions & 2 deletions tap_polarsh/tap.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
from tap_polarsh.client import PolarStream

OPENAPI_URL = "https://api.polar.sh/openapi.json"
STREAMS: list[PolarStream] = [
STREAMS: t.Sequence[type[PolarStream]] = [
streams.Organizations,
streams.Repositories,
streams.Issues,
Expand Down Expand Up @@ -55,7 +55,7 @@ def discover_streams(self) -> list[Stream]:
Returns:
A list of Neon Serverless Postgres streams.
"""
streams: list[PolarStream[str]] = []
streams: list[PolarStream] = []
openapi_schema = self.get_openapi_schema()

for stream_type in STREAMS:
Expand Down

0 comments on commit f62833c

Please sign in to comment.