Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Divide up IDs into individual scripts for each subsystem #74

Closed
Cyco12 opened this issue Jan 26, 2019 · 4 comments
Closed

Divide up IDs into individual scripts for each subsystem #74

Cyco12 opened this issue Jan 26, 2019 · 4 comments
Assignees
@Cyco12
Labels
Co-Processor: Roborio Any code related to the Roborio enhancement New feature or request Language: Kotlin

Comments

@Cyco12
Copy link
Contributor

Cyco12 commented Jan 26, 2019

This'll further improve performance by only calling IDs scripts where necessary as well as make them easier to maintain/read for each subsystem.
@Cyco12 Cyco12 added enhancement New feature or request Co-Processor: Roborio Any code related to the Roborio Language: Kotlin labels Jan 26, 2019
@Cyco12
Copy link
Contributor Author

Cyco12 commented Jan 26, 2019

Make sure to resolve #72 before implementing this.

@Cyco12 Cyco12 self-assigned this Jan 31, 2019
@Cyco12
Copy link
Contributor Author

Cyco12 commented Feb 4, 2019

In progress on https://github.com/Reset-Robotics/2019-robot-code/tree/dev-id-overhaul

Currently IDs are still non-functional.

@Cyco12 Cyco12 closed this as completed Feb 4, 2019
@Cyco12 Cyco12 reopened this Feb 4, 2019
@Cyco12
Copy link
Contributor Author

Cyco12 commented Feb 14, 2019

IDs are being replaced by organized data classes for each subsystem. Functional WIP on https://github.com/Reset-Robotics/2019-robot-code/tree/id-structs-overhaul

@Cyco12
Copy link
Contributor Author

Cyco12 commented Feb 20, 2019

Implemented in ba1207a.

@Cyco12 Cyco12 closed this as completed Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Cyco12 Cyco12

Labels
Co-Processor: Roborio Any code related to the Roborio enhancement New feature or request Language: Kotlin
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Cyco12