Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unsubscribe count field #161

Closed
jirenius opened this issue Jun 5, 2020 · 1 comment
Closed

Unsubscribe count field #161

jirenius opened this issue Jun 5, 2020 · 1 comment
Assignees
@jirenius
Labels
enhancement New feature or request

Comments

@jirenius
Copy link
Collaborator

jirenius commented Jun 5, 2020

Issue

When a client unsubscribes to a resource, the unsubscribe request should have an option count field that states the number of unsubscribes to perform, instead of sending multiple successive unsubscribe requests.

Multiple subscriptions may build up if a call request returns a resource reference for a resource already subscribed.

Notes

  • Requires a PATCH version update to the RES Protocol
  • Only affects RES Client protocol. Service are unaffected.
  • Clients should fall back to legacy behavior if the gateway responds with 1.2.0 or less to the version request,
@jirenius jirenius added the enhancement New feature or request label Jun 5, 2020
@jirenius jirenius self-assigned this Jun 5, 2020
jirenius added a commit that referenced this issue Jun 5, 2020
@jirenius
GH-161: Added count field to Unsubscribe request in RES Client Protocol.
8666d3b
jirenius added a commit that referenced this issue Jun 5, 2020
@jirenius
GH-161: Added handling of unsubscribe count field.
950f166
jirenius added a commit that referenced this issue Jun 5, 2020
@jirenius
GH-161: Added unsubscribe count field tests.
47a6ffc
jirenius added a commit that referenced this issue Jun 5, 2020
@jirenius
GH-161: Fixed broken test.
2240fdb
jirenius added a commit that referenced this issue Jun 5, 2020
@jirenius
Merge pull request #162 from resgateio/feature/gh-161-unsubscribe-cou…
0b333c8 
…nt-field

Feature/gh 161 unsubscribe count field
@jirenius
Copy link
Collaborator Author

jirenius commented Jun 5, 2020

Resolved in #162

@jirenius jirenius closed this as completed Jun 5, 2020
@jirenius jirenius mentioned this issue Jun 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jirenius jirenius

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jirenius