remove unused "parseOptions" option, and add default options in lexer #52
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did:
lib/index.js
was unusued, removed itreshape/parser
)Why:
Reshape by default calls this function with
(input, opts.parseOptions, opts)
. In none of the tests wasparseOptions
defined, so error tests kept failing by trying to accessundefined.filename
when generating errors. Looking atreshape/parser
, I realised that lexer has just to explicitly start with empty config if none is given.