Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused "parseOptions" option, and add default options in lexer #52

Merged
merged 1 commit into from
Jun 1, 2018

Conversation

adamkiss
Copy link
Contributor

What I did:

  • parseOptions in lib/index.js was unusued, removed it
  • added default empty object as an options to lexer (a la reshape/parser)

Why:
Reshape by default calls this function with (input, opts.parseOptions, opts). In none of the tests was parseOptions defined, so error tests kept failing by trying to access undefined.filename when generating errors. Looking at reshape/parser, I realised that lexer has just to explicitly start with empty config if none is given.

@jescalan jescalan merged commit d6d7874 into reshape:master Jun 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants