STARK: Change to use reference for the filename in the FMVWidget

residualvm · Jun 9, 2018 · c7bc747 · c7bc747
1 parent 20d54d7
commit c7bc747
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/engines/stark/ui/menu/fmvmenu.cpp b/engines/stark/ui/menu/fmvmenu.cpp
@@ -195,7 +195,7 @@ FMVWidget::FMVWidget(Gfx::Driver *gfx, int fmvIndex) :
 }
 
 void FMVWidget::onClick() {
-	StarkUserInterface->requestFMVPlayback(Common::String(_filename));
+	StarkUserInterface->requestFMVPlayback(_filename);
 }
 
 bool FMVWidget::isMouseInside(const Common::Point &mousePos) const {

diff --git a/engines/stark/ui/menu/fmvmenu.h b/engines/stark/ui/menu/fmvmenu.h
@@ -100,7 +100,7 @@ class FMVWidget {
 	static const uint32 _textColorHovered = 0xFF961E1E;
 	static const uint32 _textColorDefault = 0xFF000000;
 
-	Common::String _filename;
+	const Common::String &_filename;
 	VisualText _title;
 
 	int _width;