This repository has been archived by the owner on Jun 8, 2022. It is now read-only.
GSOC WME3D: Binary .X lexer #1662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aquadran
reviewed
Aug 10, 2020
aquadran
reviewed
Aug 10, 2020
| uint vertexNormalCount = readInt(lexer); | ||
| assert(vertexNormalCount == _vertexCount); | ||
| uint vertexNormalCount = lexer.readInt(); | ||
| // assert(vertexNormalCount == _vertexCount); |
There was a problem hiding this comment.
The demo of "On the track of dinosaurs" has a model with fewer normals than vertices. So this condition is actually not guaranteed to be true.
Botje
reviewed
Aug 10, 2020
GunnarBirke
force-pushed
the
binary-x-lexer
branch
from
d937a44
to
7f8634e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.