This repository has been archived by the owner on Jun 8, 2022. It is now read-only.
GRIM: Rewrite of PatchR #617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 3, 2012 10:30
This new version of patchr is based on bsdiff format (although it doesn't share code with it, since it has been written from scratch) All patches written for the old version have been ported to this one.
|
The patch for ha.lua works. I don't remember what was wrong with si, though. |
|
si is working fine. I can't actually remember what the change was, but without the patch the scene has a ton of errors. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #606, with a major/minor versioning scheme and more error handling code.
@klusark and Giucam: I've tested all patches, except for those for si.lua and ha.lua. Could you check if they work correctly? I don't know how to trigger the bugs that these patches resolve.
Original description:
This commit introduces a new version of patchr, written from scratch, but heavily based on bsdiff format (http://www.daemonology.net/bsdiff/).
This new format is totally binary, and comes with a tool (diffr) to build automatically the patches from the old and the new file.
For more information about the new format, see the documentation alleged to the pull request of diffr and patchr tools in residualvm-tools.
The diffr tool, with the new -b option of luac, makes the process of patching lua scripts much more easy, I'll write a guide for that.
Furthermore it can patch efficiently large files, since the whole old file is not loaded anymore in the ram and it doesn't make memmoves on larges portions of the file.
All patches written for the old version have been ported to this one.