Skip to content
This repository has been archived by the owner on Jun 8, 2022. It is now read-only.

MATH: Allow Rotations to have a selectable Euler Order #936

Merged
merged 3 commits into from Jun 23, 2014

Conversation

JoseJX
Copy link
Contributor

@JoseJX JoseJX commented Jun 19, 2014

This is the first step to improving the Quaternion implementation to fix attach/detach. In this patch, I add a selectable Euler Order parameter for Rotation3D. I also replace some of the existing Quaternion usage where it was immediately converted into a Matrix, removing the middle step of building a Quaternion first. I also have a branch where I adapted the old Rotation code to test my implementation against that. This isn't really mergable, but can be found here: https://github.com/JoseJX/residualvm/tree/Rotation3D_OldTest

This should be standalone, but if you'd rather that I include the Quaternion code at the same time, that's okay too. I still need to add a check for gimbal lock and resolve that in the Matrix -> Euler implementation, but I'd like some feed back on this first.

@klusark
Copy link
Member

klusark commented Jun 19, 2014

Looks good to me.

@aquadran
Copy link
Member

code needs proper formatting

@JoseJX
Copy link
Contributor Author

JoseJX commented Jun 21, 2014

I took out the comment for the constructor because it's not used directly. I also fixed the indentation in the test.

klusark added a commit that referenced this pull request Jun 23, 2014
MATH: Allow Rotations to have a selectable Euler Order
@klusark klusark merged commit b09c316 into residualvm:master Jun 23, 2014
@JoseJX JoseJX deleted the ExpandRotation3D branch June 23, 2014 14:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants