This repository has been archived by the owner on Jun 8, 2022. It is now read-only.
MATH: Allow Rotations to have a selectable Euler Order #936
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first step to improving the Quaternion implementation to fix attach/detach. In this patch, I add a selectable Euler Order parameter for Rotation3D. I also replace some of the existing Quaternion usage where it was immediately converted into a Matrix, removing the middle step of building a Quaternion first. I also have a branch where I adapted the old Rotation code to test my implementation against that. This isn't really mergable, but can be found here: https://github.com/JoseJX/residualvm/tree/Rotation3D_OldTest
This should be standalone, but if you'd rather that I include the Quaternion code at the same time, that's okay too. I still need to add a check for gimbal lock and resolve that in the Matrix -> Euler implementation, but I'd like some feed back on this first.