Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spring Boot emits warnings about invalid actuator endpoint name #286

Closed
dberrueta-atlassian opened this issue Nov 23, 2018 · 5 comments
Closed

Spring Boot emits warnings about invalid actuator endpoint name #286

dberrueta-atlassian opened this issue Nov 23, 2018 · 5 comments
Labels
needs investigation
Milestone
0.14.0

Comments

@dberrueta-atlassian
Copy link

When using the Spring Boot 2.x starter, the application emits two warnings on startup:

o.s.boot.actuate.endpoint.EndpointId : Endpoint ID 'circuitbreaker-events' contains invalid characters, please migrate to a valid format.
o.s.boot.actuate.endpoint.EndpointId : Endpoint ID 'ratelimiter-events' contains invalid characters, please migrate to a valid format.

I am not sure yet what the impact of these warnings is, but we should rename the endpoints of the actuators provided with the Resilience4j Spring Boot 2.x starter.
@RobWin
Copy link
Member

RobWin commented Nov 28, 2018

Which Spring Boot 2 Version do you use?
Would you like to create a PR?

@berrueta
Copy link
Contributor

Steps to reproduce:

  1. Go to https://start.spring.io and create a new project (add the 'web' dependency). At the moment this uses Spring Boot 2.1.0.
  2. Add dependency on io.github.resilience4j:resilience4j-spring-boot2:0.13.2
  3. Run the application (mvn spring-boot:run) and observe the warnings in the logs.

Downgrading Spring Boot to 2.0.6 stops the warning, so this must be a very new restriction.

@RobWin
Copy link
Member

RobWin commented Nov 28, 2018

Yes, I haven't seen it before.

@berrueta
Copy link
Contributor

The warning was introduced here: spring-projects/spring-boot#14840

@storozhukBM storozhukBM added this to the 0.14.0 milestone Nov 29, 2018
berrueta added a commit to berrueta/resilience4j that referenced this issue Dec 11, 2018
@berrueta
resilience4j#286: Change endpoint names to ensure compatibility with …
ee88f66 
…future SB releases

Since Spring Boot 2.1.x, the applications emit a warning on startup
if the endpoint name contains a dash or a dot. Future versions of
Spring Boot may ban these symbols completely.
@berrueta berrueta mentioned this issue Dec 11, 2018
Merged
@berrueta
Copy link
Contributor

Sorry for the delay. I wanted to experiment a bit to try to minimise the impact of the change.

Please see PR #300 .

RobWin pushed a commit that referenced this issue Dec 13, 2018
@berrueta @RobWin
Change endpoint names to ensure compatibility with future SB releases (…
85107d7 
…#300)

* #286: Change endpoint names to ensure compatibility with future SB releases

Since Spring Boot 2.1.x, the applications emit a warning on startup
if the endpoint name contains a dash or a dot. Future versions of
Spring Boot may ban these symbols completely.

* Update tests to reflect new endpoint URL
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs investigation
Projects
None yet
Milestone
0.14.0
Development

No branches or pull requests
4 participants
@berrueta @storozhukBM @RobWin @dberrueta-atlassian