Circuitbreaker metrics is outdated #634
Comments
RobWin
pushed a commit
that referenced
this issue
Sep 18, 2019
mlegore
added a commit
to SiftScience/resilience4j
that referenced
this issue
Oct 7, 2019
* Issue resilience4j#500: Honor global configs in resilience4j-ratpack (resilience4j#501) * Refactored resilience4j-metrics (resilience4j#507) * Removed deprecated time-based methods and replaced them by methods with use Duration. (resilience4j#508) * Fixed class level annotations (resilience4j#521) * Fixed ratpackk method interceptor and simplifying other method interceptors (resilience4j#522) * Use single retry registry, update config paths (resilience4j#524) * Added decorateFutureSupplier to timeLimiter as non-static method. (resilience4j#525) * Removed deprecated methods and classes. (resilience4j#512) * Issue resilience4j#518: Added decorators to CircuitBreaker and Retry for Supplier… (resilience4j#519) * Unwrap the ExecutionException in TimeLimiter and rethrow the cause at decorateFutureSupplier function (resilience4j#529) * Issue resilience4j#515: Aspects ordering update (resilience4j#534) * resilience4j#515 ordering update * resilience4j#515 aspects ordering update * resilience4j#515 unit test update * resilience4j#515 test coverage increase * Fix typo in javadoc (resilience4j#535) * Issue resilience4j#530: Improved the conditioning (resilience4j#533) * Issue resilience4j#538: Removed retry interval value contraint(resilience4j#539) * Properly handle onComplete for ratpack circuit transformer by releasing permission (resilience4j#542) * Properly handle "cancellations" of a ratpack promise for bulkheads (resilience4j#543) * Issue resilience4j#544: Fixes bug that CircuitBreaker stays in half open when exceptions are ignored. (resilience4j#545) * Deleted examples folder * Updated CircuitBreakerStateMachineTest * Updated RELEASENOTES * Updated version to 1.0.0-SNAPSHOT * Issue resilience4j#537: Resilience4j Aspects should be only available when AspectJ is on classpath * Issue resilience4j#488: Added ThreadPoolBulkhead metrics to micrometer. (resilience4j#549) * Issue resilience4j#547: Added a Sliding Time Window implementation to measure met… (resilience4j#556) * Issue resilience4j#547: Added a Sliding Time Window implementations to measure metrics. * Issue resilience4j#547: Added a Fixed size Sliding Window implementation which aggregates the last N calls and replaced the existing RingBitSet. * Issue resilience4j#540 Support auto complete config in spring boot (resilience4j#566) * Issue resilience4j#562: State transition must be validated before the transition happens * Issue resilience4j#562: State transition must be validated before the transition happens. * Issue resilience4j#547: Adapted CircuitBreakerConfigurationProperties to support … (resilience4j#564) * Issue resilience4j#547: Adapted CircuitBreakerConfigurationProperties to support the new sliding window types. * Improved JavaDoc in CircuitBreakerConfig. * Issue resilience4j#547: Added new metrics to Spring Boot HealthIndicator. (resilience4j#569) * Issue resilience4j#571: Spring Boot 1 and Spring Boot 2 custom endpoints should not be mandatory. (resilience4j#572) * Issue resilience4j#568: Changed the logic in the CircuitBreaker to handle exception so that it is also possible to count exceptions as a success. (resilience4j#573) The list of ignored exceptions has always precedence. If an exception is ignored it neither counts as a success nor failure. If the list of recorded exceptions only contains some exceptions, all others count as a success, unless they are not part of the list of ignored exceptions. * Issue resilience4j#547: Added slow call rate to CircuitBreakerMetricsCollector an… (resilience4j#574) * Issue resilience4j#547: Added slow call rate to CircuitBreakerMetricsCollector and TaggedCircuitBreakerMetrics. * Issue resilience4j#560: Fixed bug when using a lamda as a Feign fallback (resilience4j#576) * Added some tests to CircuitBreakerRegistryTest * Added some tests to CircuitBreakerRegistryTest * Added some tests to CircuitBreakerRegistryTest * Issue resilience4j#531: Added events to TimeLimiter (resilience4j#583) * Issue resilience4j#531: Refactored TimeLimiter to emit Events. * Issue resilience4j#571: Spring Boot HealthIndicators use the registries now * Issue resilience4j#559: Support of @CIRCUITBREAKER annotation along with @FeignClient (resilience4j#579) * Updated version to 1.0.0-SNAPSHOT * Issue resilience4j#581: Some RxJava2 or Reactor operators like ZipObserver are ca… (resilience4j#594) * Issue resilience4j#581: Some RxJava2 or Reactor operators like ZipObserver are cancelling (disposing) a second Observable when the first observable is complete. This is because an operator like zip must combine two events. It makes no sense to consume further events of the second observable when the first is completed. Unfortunately the cancellation is bad for the CircuitBreakerOperator, since no success is recorded even if an emit was emitted successfully. Solution: The CircuitBreaker operator and BulkHead operator could track if an event has been emitted successfully (onNext). And when dispose/cancel is invoked, the operator either invokes onSuccess/onComplete or releasePermission. * Fixed some JavaDoc * Fixed CircuitBreaker HalfOpenState. HalfOpenState should not use a time-based sliding window type, but always a count-based sliding window type. (resilience4j#597) * Issue resilience4j#531: Added Dropwizard metrics for TimeLimiter (resilience4j#586) * Fixed CircuitBreaker HalfOpenState. HalfOpenState should not use a time-based sliding window type, but always a count-based sliding window type. * Replaced deprecated methods in tests. (resilience4j#598) * Issue resilience4j#531: Time limiter micrometer (resilience4j#599) * Issue resilience4j#531: Added Prometheus metrics to TimeLimiter (resilience4j#600) * Refactored TaggedTimeLimiterMetrics to be similar to TaggedCircuitBreakerMetrics (resilience4j#601) * Issue resilience4j#546: Added resilience4j-spring-cloud modules (resilience4j#550) * Changed Spring Boot from compileOnly to compile dependency * Fixed few Java Docs + removed compilation warnings * Set up CI with Azure Pipelines [skip ci] * Try other options for azure pipeline (resilience4j#609) * Try other options for azure pipeline * Try to switch of ratpack tests with accordance to Travis script * Fix Azure mapping * Fix spec annotation * Add OS matrix * Enable only linux in matrix * Azure badge * Fix bulkhead test (resilience4j#611) * Fix bulkhead test * Enable matrix again * Issue resilience4j#603: Added a feature the add a RegistryEventConsumer to every Registry (resilience4j#606) * Issue resilience4j#607: The CircuitBreakerHealthIndicator and RateLimiterHealthIn… (resilience4j#615) * Issue resilience4j#607: The CircuitBreakerHealthIndicator and RateLimiterHealthIndicator should be disabled by default. Otherwise the application health status is DOWN when a CircuitBreaker is open which is not what users want. * Updated release notes. * Switch off unstable building agents * Fixed bug in prometheus metrics publisher and increased code coverage (resilience4j#616) * Tests speedup (resilience4j#617) * Tests speedup with reuse of spring context * Few fixes for tests * Speedup ratpack tests * Configure retry in rxjava tests for speed up * Configure retry in ratpack tests for speed up * Configure timeout in rate limiter tests for speed up * Configure timeouts in tests for speed up * Some debug output clean up * After merge fixes * Updated version to 1.0.0-SNAPSHOT * Depending on the number of cpus, the default core threadpool size can be less than 10 which causes the test to fail. (resilience4j#620) * Issue resilience4j#618: Expose config property to disable writable stack traces (resilience4j#619) * Issue resilience4j#618: Expose config property to disable writable stack traces (resilience4j#623) * Fix package declaration (resilience4j#633) * Tests speedup - flaky acquirePermissionAndMetrics fixup (resilience4j#617) (resilience4j#631) * Fixed typo in Reactor's `Publisher are not supported by this operator` (resilience4j#635) * Issue resilience4j#235: TimeLimiter as rx transformer (resilience4j#624) * Issue resilience4j#634: Added slow call rate to Dropwizard Metrics (resilience4j#632) * Fixed sonar findings (resilience4j#637) * Issue resilience4j#235: TimeLimiter as a Reactor operator (resilience4j#636) * Removed unused imports. * Fixed sonar findings * Remove javax.xml.ws.WebServiceException (resilience4j#638) * add overview and patterns to readme (resilience4j#641) * Tests speedup - flaky waitingThreadIsInterrupted fixup (resilience4j#617) (resilience4j#639) * resilience4j#625 Fix for some issues raised by sonar (resilience4j#621) * Make this config explicitly immutable * Explicit doc for config field * Temporary change, to trigger warning from sonar. * Make this config explicitly immutable * Fix few other sonar complaints * Disable non-relevant check in sonar * Remove unused import * Propagate right info about thread interruption to callers via exceptions and Thread.interrupted flag * Fixes after merge with master * Additional tests and code cleanup * Tests fix * Update documentation about thread interruption contract. Update release notes. * Make common exception type for RateLimiter and Bulkhead * Code review comments fixed * More metrics from sonar * Remove quality gate metrics while we're dealing with code duplicates * Issue resilience4j#646: Illegal state transition from HALF_OPEN to OPEN/CLOSED. (resilience4j#647) * Added more overview and patterns to readme (resilience4j#648) * Added slow call count metrics (resilience4j#640) * Replaced tags slow_successful and slow_failed by successful and failed. * Issue resilience4j#607: Added a config property to disable CircuitBreaker and Rat… (resilience4j#649) * Updated RELEASE NOTES * Updated version to 1.1.0 * Updated version to 1.1.1-SNAPSHOT * Remove hibernate-validator dependency (resilience4j#660) * Add back interval function * Add test for wait interval
hexmind
pushed a commit
to hexmind/resilience4j
that referenced
this issue
Oct 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I've created #632 to fix:
The text was updated successfully, but these errors were encountered: