Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added GST validations to Sales Invoice #21

Merged
merged 15 commits into from
Mar 28, 2022

Conversation

vorasmit
Copy link
Collaborator

@vorasmit vorasmit commented Mar 8, 2022

Summary of Changes

  • Improved Get GST Accounts --> based on PR refactor!: Clean GST accounts table and patches #6
  • Improved existing validation of Sales Invoice Number
  • Added GST Settings where users can opt out if they are unregistered.
  • Validate same items with different Item Tax Template
  • Validate GST Accounts in Sales Invoice.
  • Validate if mandatory fields are present.
  • Fixed HSN Validation

GST Settings

image

Check where taxes are not applicable

image

Check where incorrect tax accounts could be used

image

Mandatory Field Validation

image

TODO: In later PRs

@sagarvora sagarvora removed their request for review March 12, 2022 13:04
@sagarvora sagarvora merged commit bf8bc38 into resilient-tech:develop Mar 28, 2022
@sagarvora sagarvora deleted the gst_validations branch March 28, 2022 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants