Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

models.os.getMaxSatisfyingVersion cannot return a dev image #422

Closed
Page- opened this issue Oct 16, 2017 · 1 comment
Closed

models.os.getMaxSatisfyingVersion cannot return a dev image #422

Page- opened this issue Oct 16, 2017 · 1 comment
Assignees
@pimterry
Labels
bug

Comments

@Page-
Copy link
Contributor

Page- commented Oct 16, 2017

This is due to semver.maxSatisfying(['2.0.8+rev1.prod','2.0.8+rev1.dev'], '2.0.8+rev1.dev') returning '2.0.8+rev1.prod', so even with maximum specificity you still get given the prod image (presumably because p > d and build metadata is ignored for comparsions)
@Page- Page- added the bug label Oct 16, 2017
This was referenced Oct 17, 2017
Closed
Merged
@pimterry
Copy link
Contributor

Fixed and released in 7.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pimterry pimterry

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Page- @pimterry