Fix bug in log stream setup error reporting #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thgreasi
approved these changes
Aug 9, 2018
|
I feel like a primitive that the coffeescript linter didn't catch that... |
Fixes #559 Change-type: patch Signed-off-by: Tim Perry <tim@resin.io>
pimterry
force-pushed
the
559-log-setup-errors
branch
from
a5044b1
to
76fbbb1
Compare
|
VersionBot failed to carry out a status check for the above pull request here: #560. The reason for this is: |
ghost
merged commit 
ghost
removed
the
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #559
Tiny typo, but it results in an uncaught exception and no reported error for any failures in the initial logs subscription request.
Change-type: patch
Signed-off-by: Tim Perry tim@resin.io